On Sat, Jun 20, 2009 at 01:50:12PM +0200, Sam Ravnborg wrote: > On Fri, Jun 12, 2009 at 10:13:31AM +0200, Konrad Eisele wrote: > > I'll shortly send the sparc-leon patches as message relies to this > > thread. I applied the changes that Julian suggested. Thank you for the > > comments. Waiting for more. > > Hi Konrad. > Some general comments. > > 1) subject/changelog > When writing your changelog keep the subject (the first line > or the changelog) and the body apart with a single line. > You failed to do so and the result is some over-long subject lines. > > 2) sign-off your patches > See Documentation/Submitting-patches > > The syntax is simple: > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> The subject line needs fixing too. It should read: sparc,leon: CONFIG_SPARC_LEON option and leon specific files When you use "git send-email" it will add [PATCH n/m], so do not worry about that. sparc - sibnals that this is sparc specific. ,leon - signals that this is leon specific within sparc. So adding these small things to your subject allows us to see where this belongs when we look at 500 new patches applied to -linus. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
