On Sun, Jan 4, 2009 at 19:43, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Hi Julian. > > As a first step before trying to merge these two files > all EXPORT_SYMBOL() that exports symbols defined in .C files > shall be moved out to their respective definition site. Ok. > You also need to pay attention to all the > prototypes and extern's in the sparc_kysms.c files. > > If they are still needed they belong to a header file. Ok. > This is all straightforward to do it just take some time. > And if you keep your patches sufficienly small then it > should be easy to review too. Ok. Some explanation: This was a (wrong) first step before doing the unification of arch/sparc/prom/*. I think I'll take some of the lower hanging fruit first. After I kill PROMLIB_INTERNAL and the exported definitions of __prom_*(), I think I'll work on unifying include/asm/oplib_*.h as that will make later changes smaller. As for moving the EXPORT_SYMBOL()s out of here, I think I'll leave the code as it is and eliminate most of the code in kernel/sparc_ksyms_*.c as a final step. Thanks for the advice! -- Julian Calaby Email: julian.calaby@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
