On Sun, Jan 4, 2009 at 19:51, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Looks good. > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Thanks! > As a natural next step you could eliminate the following: > #ifdef CONFIG_SPARC32 > strcpy(p->name, name); > #endif > > by moving this strcpy() to the prom_* functions > for sparc32. It's happening soon, but there's other changes that have to happen at the same time to have it not be useless code, so that's happening with some of the cleanups of the prom/tree_*.c files prior to their unification. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html