Re: 16550 serial support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Josip Rodin <joy@xxxxxxxxxxxxxx>
Date: Sun, 14 Sep 2008 13:12:40 +0200

> On Sat, Sep 13, 2008 at 09:31:52PM -0700, David Miller wrote:
> > @@ -2177,7 +2178,9 @@ uart_report_port(struct uart_driver *drv, struct uart_port *port)
> >  	printk(KERN_INFO "%s%s%s%d at %s (irq = %d) is a %s\n",
> >  	       port->dev ? port->dev->bus_id : "",
> >  	       port->dev ? ": " : "",
> > -	       drv->dev_name, port->line, address, port->irq, uart_type(port));
> > +	       drv->dev_name,
> > +	       drv->tty_driver->name_base + port->line,
> > +	       address, port->irq, uart_type(port));
> >  }
> >  
> >  static void
> 
> BTW, while we're at it - since the data type of uart_port->iobase is larger
> now, the two snprintf()'s which print it out started complaining:
> 
> drivers/serial/serial_core.c: In function 'uart_report_port':
> drivers/serial/serial_core.c:2159: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
> drivers/serial/serial_core.c:2159: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
> drivers/serial/serial_core.c:2163: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
> drivers/serial/serial_core.c:2163: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
> 
> After the following trivial patch it goes quiet:

I already have that patch in my tree, but thanks anyways :)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux