On Sat, Sep 13, 2008 at 09:31:52PM -0700, David Miller wrote:
> @@ -2177,7 +2178,9 @@ uart_report_port(struct uart_driver *drv, struct uart_port *port)
> printk(KERN_INFO "%s%s%s%d at %s (irq = %d) is a %s\n",
> port->dev ? port->dev->bus_id : "",
> port->dev ? ": " : "",
> - drv->dev_name, port->line, address, port->irq, uart_type(port));
> + drv->dev_name,
> + drv->tty_driver->name_base + port->line,
> + address, port->irq, uart_type(port));
> }
>
> static void
BTW, while we're at it - since the data type of uart_port->iobase is larger
now, the two snprintf()'s which print it out started complaining:
drivers/serial/serial_core.c: In function 'uart_report_port':
drivers/serial/serial_core.c:2159: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
drivers/serial/serial_core.c:2159: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
drivers/serial/serial_core.c:2163: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
drivers/serial/serial_core.c:2163: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int'
After the following trivial patch it goes quiet:
--- drivers/serial/serial_core.c~ 2008-09-14 13:08:33.000000000 +0200
+++ drivers/serial/serial_core.c 2008-09-14 13:08:33.000000000 +0200
@@ -2156,11 +2156,11 @@
switch (port->iotype) {
case UPIO_PORT:
snprintf(address, sizeof(address),
- "I/O 0x%x", port->iobase);
+ "I/O 0x%lx", port->iobase);
break;
case UPIO_HUB6:
snprintf(address, sizeof(address),
- "I/O 0x%x offset 0x%x", port->iobase, port->hub6);
+ "I/O 0x%lx offset 0x%x", port->iobase, port->hub6);
break;
case UPIO_MEM:
case UPIO_MEM32:
--
2. That which causes joy or happiness.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
