On Wed, 2007-10-17 at 21:36 +1000, Benjamin Herrenschmidt wrote: > > I find it ironic that you add of_get_pci_dev_node() as a function > > which gets the node and grabs a reference to it, and then the very > > first usage you make of it doesn't drop the reference at all. > > > > That reference grabbing aspect of the new interface is obviously very > > useful! :-) > > > > Kidding aside (I realize that in this case probably the driver never > > unregisters and therefore the reference never needs to be released) > > it's really much nicer to add facilities when you have patches in hand > > that actually use them. > > I think in this case, it's mostly a matter of consistency... pretty much > everything that returns a device_node grabs a reference... except > pci_device_to_OF_node :-) Yeah, it's a matter of the API being error-prone in that most routines take a reference for you, but this one doesn't. > I think Michael is trying to address that, and axon-msi happens to be > something he wrote so a good candidate for an initial conversion :-) Yep, I wanted at least one user in tree with the patch. I plan to convert other pci_device_to_OF_node() users to use the refcounted version over time. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
