On Wed, Oct 17, 2007 at 05:12:27PM +1000, Michael Ellerman wrote:
> +struct device_node *of_get_pci_dev_node(struct pci_dev *pdev)
> +{
> + return of_node_get(pci_device_to_OF_node(pdev));
> +}
[...]
> - dn = of_node_get(pci_device_to_OF_node(dev));
> + dn = of_get_pci_dev_node(dev);
Is this really useful or wise?
As a matter of personal taste, I find stuff like this clutters
and confuses my mind. I go to read new code, and I run across some
routine I haven't heard of before ... e.g. of_get_pci_dev_node(),
so now I have to look it up to see what it does. A few minutes later,
I realize that its just a pair of old freinds (of_node_get and
pci_device_to_OF_node) and so now I have to make mental room for it.
Tommorrow, or 3 days later, I'm again looking at of_get_pci_dev_node()
and I'm thinking "gee what did that thing do again??"
I don't much like this style, and I've been known to submit
patches that remove stuff like this ...
--linas
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
