Re: [PATCH] sunlance probing problem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Krzysztof Helt" <krzysztof.h1@xxxxx>
Date: Sat, 12 Aug 2006 15:20:55 +0200

> The patch skips probing of the "le" device if it is a child of
> "ledma" or "lebuffer".
> 
> Signed-off-by: Krzysztof Helt (krzysztof.h1@xxxxx)

If you return "0" as the error, the caller in the device probing layer
grabs a reference to the device which will be a leak of the undelying
of_device object.

A better way to fix this is probably to only match "le" and have
the probe code check the device parent for "ledma" or "lebuffer".
You should be able to confine all of your changes to the probe
match table and sunlance_sbus_probe().

Could you implement it like that and give it a test?

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux