I applied these patches and then had to revert this one because a lot of Smatch was written with the assumption that we could figure out the type promotion from calling get_type() on the comparison condition... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe smatch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html