Hi Dan Your patch wasn't quite sufficient, since it didn't cover the (rather common) case of ptr-arr - the array didn't undergo pointer decay in the eyes of types_equiv. This seems to work ok for check_kernel_printf, but I haven't done anything to see if this breaks the rest of smatch. Rasmus Villemoes (3): smatch_type.c: fix type of pointer diff smatch_type.c: comparison expressions always have type int check_kernel_printf.c: warn about "%lx", (long)ptr check_kernel_printf.c | 31 +++++++++++++++++++++++++++++++ smatch_type.c | 12 +++++++++--- 2 files changed, 40 insertions(+), 3 deletions(-) -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe smatch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html