On Wed, Aug 19, 2015 at 09:33:54PM -0400, Oleg Drokin wrote: > And another false negative class: > > lustre/ptlrpc/nrs.c:1058 nrs_svcpt_cleanup_locked() warn: we tested 'hp' before and it was 'false' > > bool hp = false; > … > again: > … > 1058 if (!hp && nrs_svcpt_has_hp(svcpt)) { > hp = true; > goto again; > } > > So we see that hp is always false at the start of the function, we meet the comparison and think it's still false, > but in fact there's one another path leading to there once we do the goto. I will silence this one. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe smatch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html