On Fri, Mar 08, 2013 at 11:45:48AM +0800, Xiechanglong wrote: > I think, this is also a false postive > > > New smatch warnings: > > drivers/net/team/team.c:1771 team_ethtool_get_drvinfo() error: strlcpy() '"3.9.0-rc1-mm1-00315-g391ef7f"' too small (29 vs 32) > > > > 3066af58 Flavio Leitner 2013-01-05 @1771 strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version)); Yeah. What's happening here is that this is a two part test. The first part creates a list in smatch_data/kernel.sizeof_param by running smatch_scripts/gen_sizeof_param.sh on the info file. Apparently someone must have done something like: strlcpy(foo, bar, sizeof(bar)); So it now has this line in kernel.sizeof_param: strlcpy 2 1 It's going to cause tons and tons of false positives! I've added "strlcpy 2 1" to smatch_data/kernel.sizeof_param.remove and pushed it. If you still have the info file from this kernel then it would be interesting to run: grep "sizeof_param 'strlcpy' 2 1" was_warns.txt-info It's probably a bug. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe smatch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
