On Mon, 2023-07-31 at 17:43 -0700, Alexei Starovoitov wrote: > I still think it's a hack, but its blast radius is nicely contained. > And since I cannot propose any better I'm ok with it. > > Patches 1-2 can be squashed into one. > Just like patches 3-6 as a single patch for selftests. > > But before proceeding I'd like an explicit ack from netdev maintainers. Just to state the obvious, I carry my personal bias on this topic due to my background ;) My perspective is quite similar to Alexei's one: the solution is not extremely elegant, but is very self-contained; it looks viable to me. WRT the specific code, I think the additional checks on the 'protocol' value after the 'update_socket_protocol()' call should be dropped: the user space can already provide an arbitrary value there and the later code deal with that. Cheers, Paolo
