Re: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 9, 2020 at 9:11 AM Ethan Edwards
<ethancarteredwards@xxxxxxxxx> wrote:
>
> `sizeof buf` changed to `sizeof(buf)`
>
> Signed-off-by: Ethan Edwards <ethancarteredwards@xxxxxxxxx>
> ---
>  security/selinux/ss/conditional.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why are you reposting this when I applied your original patch last week?

https://lore.kernel.org/selinux/CAHC9VhSakA7V99+tkvLLZHohiupWmjSFxSZLWZT4-Gwr5Cc-XA@xxxxxxxxxxxxxx

> diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
> index 0cc7cdd58465..90a2f5927e55 100644
> --- a/security/selinux/ss/conditional.c
> +++ b/security/selinux/ss/conditional.c
> @@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
>         if (!booldatum)
>                 return -ENOMEM;
>
> -       rc = next_entry(buf, fp, sizeof buf);
> +       rc = next_entry(buf, fp, sizeof(buf));
>         if (rc)
>                 goto err;
>
> @@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp)
>         u32 i, len;
>         int rc;
>
> -       rc = next_entry(buf, fp, sizeof buf);
> +       rc = next_entry(buf, fp, sizeof(buf));
>         if (rc)
>                 return rc;
>
> --
> 2.27.0
>


-- 
paul moore
www.paul-moore.com



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux