On Tue, Jun 23, 2020 at 9:10 AM Stephen Smalley <stephen.smalley.work@xxxxxxxxx> wrote: > On Tue, Jun 23, 2020 at 8:37 AM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote: > > > > In Travis CI (Ubuntu), the shell used by Make doesn't understand > > bashisms like [[ ... ]]. Replace them with plain [ ... ] and also break > > up the conditionals for better readabilty. > > > > Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx> > > When I ran into these issues (along with some similar problems with > bashisms in some of the test scripts) in getting the testsuite to pass > on Debian and Ubuntu, I addressed it by running dkpg-reconfigure dash > and switching the default shell to bash (as noted in the README.md). > Not objecting to changing it but just noting that there are further > bashisms in the testsuite beyond the Makefiles. Agreed. I don't think requiring bash is the same problem that it may have been ~20 years ago; it would be even easier if Ubuntu hadn't decided to go with dash (/me shakes fist). Regardless of this patch, I think it might be good to add a check to the test suite to warn (fail?) if the current shell is not bash. -- paul moore www.paul-moore.com
