Re: [PATCH testsuite 1/4] Makefiles: remove bashisms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 23, 2020 at 8:37 AM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
>
> In Travis CI (Ubuntu), the shell used by Make doesn't understand
> bashisms like [[ ... ]]. Replace them with plain [ ... ] and also break
> up the conditionals for better readabilty.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>

When I ran into these issues (along with some similar problems with
bashisms in some of the test scripts) in getting the testsuite to pass
on Debian and Ubuntu, I addressed it by running dkpg-reconfigure dash
and switching the default shell to bash (as noted in the README.md).
Not objecting to changing it but just noting that there are further
bashisms in the testsuite beyond the Makefiles.

In any event,
Acked-by: Stephen Smalley <stephen.smalley.work@xxxxxxxxx>



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux