On Mon, Apr 20, 2020 at 1:38 PM Christian Göttsche <cgzones@xxxxxxxxxxxxxx> wrote: > > Am Mo., 20. Apr. 2020 um 20:30 Uhr schrieb Nicolas Iooss > <nicolas.iooss@xxxxxxx>: > > > > On Mon, Apr 20, 2020 at 4:29 PM Roberts, William C > > <william.c.roberts@xxxxxxxxx> wrote: > > > > > > We should probably add the checker so it comments on the PRs. It would have caught it > > > Before it got in tree. > > > > In this case, the bug has been introduced in 2008 ;) Anyway, I have For some reason, given the timing I thought I missed something in the review of the other patches. I guess I should have used git blame vs assuming! > > never configured lgtm.com to look on PRs, or contributed to a project > > that did this. For SELinux, I am wondering whether the hundreds of > > alerts currently reported in > > https://lgtm.com/projects/g/SELinuxProject/selinux/?mode=list could > > affect the usefulness of having it integrated to PRs. > > I think lgtm.com only shows new issues on pull requests. > For example systemd uses it and I never got an unrelated alert. Exactly, it only gripes if you add. So they will help keep the list from growing at least.
