This issue has been found using lgtm.com: https://lgtm.com/projects/g/SELinuxProject/selinux/snapshot/4946f674a6da9cc368cc826f963aedd39b6a94cf/files/python/semanage/seobject.py?sort=name&dir=ASC&mode=heatmap#x5c052fffe98aee02:1 Fixes: 49706ad9f808 ("Revised Patch for local nodecon support in semanage (was: Adding local nodecon's through semanage)") Signed-off-by: Nicolas Iooss <nicolas.iooss@xxxxxxx> --- python/semanage/seobject.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/semanage/seobject.py b/python/semanage/seobject.py index 0e9ce2900892..f2a139c970bd 100644 --- a/python/semanage/seobject.py +++ b/python/semanage/seobject.py @@ -1895,10 +1895,10 @@ class nodeRecords(semanageRecords): (rc, k) = semanage_node_key_create(self.sh, addr, mask, proto) if rc < 0: raise ValueError(_("Could not create key for %s") % addr) - if rc < 0: - raise ValueError(_("Could not check if addr %s is defined") % addr) (rc, exists) = semanage_node_exists(self.sh, k) + if rc < 0: + raise ValueError(_("Could not check if addr %s is defined") % addr) if exists: raise ValueError(_("Addr %s already defined") % addr) -- 2.26.0
