Re: [PATCH] cil: drop remaining dso.h include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2020 at 10:17 AM Joshua Brindle
<joshua.brindle@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Mar 23, 2020 at 11:35 AM William Roberts
> <bill.c.roberts@xxxxxxxxx> wrote:
> >
> > On Fri, Mar 20, 2020 at 3:08 AM Ondrej Mosnacek <omosnace@xxxxxxxxxx> wrote:
> > >
> > > On Thu, Mar 19, 2020 at 8:49 PM <bill.c.roberts@xxxxxxxxx> wrote:
> > > > From: William Roberts <william.c.roberts@xxxxxxxxx>
> > > >
> > > > Signed-off-by: William Roberts <william.c.roberts@xxxxxxxxx>
> > > > ---
> > > >  libsepol/cil/src/cil.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/libsepol/cil/src/cil.c b/libsepol/cil/src/cil.c
> > > > index c010ca2aeaf4..12cc28eff389 100644
> > > > --- a/libsepol/cil/src/cil.c
> > > > +++ b/libsepol/cil/src/cil.c
> > > > @@ -50,7 +50,6 @@
> > > >  #include "cil_binary.h"
> > > >  #include "cil_policy.h"
> > > >  #include "cil_strpool.h"
> > > > -#include "dso.h"
> > > >
> > > >  #ifndef DISABLE_SYMVER
> > > >  asm(".symver cil_build_policydb_pdb,        cil_build_policydb@LIBSEPOL_1.0");
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > Acked-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
> > >
> > Merged: https://github.com/SELinuxProject/selinux/pull/210
> >
> > Thanks
>
> It looks like this change broke building on MacOS:
>
> <inline asm>:1:1: error: unknown directive
> .symver cil_build_policydb_pdb,        cil_build_policydb@LIBSEPOL_1.0
> ^
>
> (on all of them).
>
> Previously dso.h defined DISABLE_SYMVER for Android and Apple, is
> support for those intended to go away?

No, patches forthcoming.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux