FYI: Looks like I missed a dso.h in cil.c: https://github.com/SELinuxProject/selinux/blob/master/libsepol/cil/src/cil.c#L53 Doesn't seem to be breaking anything, ill submit a patch to the mailing list. On Tue, Mar 17, 2020 at 12:46 PM Stephen Smalley <stephen.smalley.work@xxxxxxxxx> wrote: > > On Thu, Mar 12, 2020 at 5:42 PM William Roberts > <bill.c.roberts@xxxxxxxxx> wrote: > > > > On Thu, Mar 12, 2020 at 3:21 PM Stephen Smalley > > <stephen.smalley.work@xxxxxxxxx> wrote: > > > > > > On Thu, Mar 12, 2020 at 9:59 AM William Roberts > > > <bill.c.roberts@xxxxxxxxx> wrote: > > > > > > > > I will fix the subject and add the Fixes: #165 to the commit when I > > > > stage them if thats ok? > > > > > > Fixes both 165 and 204 IIUC because the real underlying issue for both was the > > > fact that he was building with LTO and it was doing the wrong thing > > > with hidden_def/hidden_proto. > > > Otherwise works for me. You can download the series from patchwork or > > > via get-lore-mbox > > > to pick up all the Acks automatically. > > > > I have no idea how to do that, Ill have to spend some time and > > familiarize myself with it. > > For now I just manually added the acks and did the edits we discussed > > and rebased ontop > > of current master. Their was a simple conflict in libsepol/src/services.c. > > > > I have them staged here: > > https://github.com/SELinuxProject/selinux/pull/207 > > > > And since their were some minor edits before they go in, ill let them > > sit a couple > > of days for any last objections. Ill merge Monday March 16 end of workday if all > > is silent. > > I merged this pull request.
