On Tue, Mar 10, 2020 at 5:09 PM <bill.c.roberts@xxxxxxxxx> wrote: > > From: William Roberts <william.c.roberts@xxxxxxxxx> > > With the old hidden_def and hidden_proto DSO infrastructure removed, > correctness of the map file becomes paramount, as it is what filters out > public API. Because of this, the wild cards should not be used, as it > lets some functions through that should not be made public API. Thus > remove the wild cards, and sort the list. > > Additionally, verify that nothing changed in external symbols as well: > > This was checked by generating an old export map (from master): > nm --defined-only -g ./src/libsepol.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map > > Then creating a new one for this library after this patch is applied: > nm --defined-only -g ./src/libsepol.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map > > And diffing them: > diff old.map new.map > > Signed-off-by: William Roberts <william.c.roberts@xxxxxxxxx> Other than the typo in the subject line, Acked-by: Stephen Smalley <sds@xxxxxxxxxxxxx> This should fix https://github.com/SELinuxProject/selinux/issues/204
