On Fri, Jan 24, 2020 at 8:17 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > On Fri, Jan 24, 2020 at 10:12 AM Stephen Smalley <sds@xxxxxxxxxxxxx> wrote: > > On 1/20/20 6:11 AM, Richard Haines wrote: > > > Test filesystem permissions using the fsopen(2), fsconfig(2), fsmount(2), > > > fspick(2) and fsmount(2) api's introduced in kernel 5.2. > > > > > > Also tests move_mount(2) using open_tree(2). > > > > > > These tests use common code from tests/filesystem. > > > > > > Signed-off-by: Richard Haines <richard_c_haines@xxxxxxxxxxxxxx> > > > > Only question I have is whether we want to enable the move_mount test > > unconditionally and let it break on kernels with the regression. Otherwise, > > Historically we haven't broken the test suite for older kernels, but I > will admit that testing older kernels is no longer a priority for me. I'd say if we expect the bug to be fixed in the stable branches of all affected (& currently supported) kernel versions, we should just let the test run unconditionally. I see little value in trying to match the exact set of broken kernel versions. So my vote is to be strict and if that turns out to cause too much trouble, we can always add some check (and be more careful next time). > > > Acked-by: Stephen Smalley <sds@xxxxxxxxxxxxx> > > > > > --- > > > tests/Makefile | 6 + > > > tests/fs_filesystem/.gitignore | 3 + > > > tests/fs_filesystem/Makefile | 16 + > > > tests/fs_filesystem/fs_common.c | 110 ++++ > > > tests/fs_filesystem/fs_common.h | 30 ++ > > > tests/fs_filesystem/fsmount.c | 89 ++++ > > > tests/fs_filesystem/fspick.c | 68 +++ > > > tests/fs_filesystem/move_mount.c | 76 +++ > > > tests/fs_filesystem/test | 833 +++++++++++++++++++++++++++++++ > > > 9 files changed, 1231 insertions(+) > > > create mode 100644 tests/fs_filesystem/.gitignore > > > create mode 100644 tests/fs_filesystem/Makefile > > > create mode 100644 tests/fs_filesystem/fs_common.c > > > create mode 100644 tests/fs_filesystem/fs_common.h > > > create mode 100644 tests/fs_filesystem/fsmount.c > > > create mode 100644 tests/fs_filesystem/fspick.c > > > create mode 100644 tests/fs_filesystem/move_mount.c > > > create mode 100755 tests/fs_filesystem/test > > -- > paul moore > www.paul-moore.com > -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc.
