Re: [PATCH 2/2] selinux-testsuite: Add fs*(2) API filesystem tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/24/20 2:17 PM, Paul Moore wrote:
On Fri, Jan 24, 2020 at 10:12 AM Stephen Smalley <sds@xxxxxxxxxxxxx> wrote:
On 1/20/20 6:11 AM, Richard Haines wrote:
Test filesystem permissions using the fsopen(2), fsconfig(2), fsmount(2),
fspick(2) and fsmount(2) api's introduced in kernel 5.2.

Also tests move_mount(2) using open_tree(2).

These tests use common code from tests/filesystem.

Signed-off-by: Richard Haines <richard_c_haines@xxxxxxxxxxxxxx>

Only question I have is whether we want to enable the move_mount test
unconditionally and let it break on kernels with the regression.  Otherwise,

Historically we haven't broken the test suite for older kernels, but I
will admit that testing older kernels is no longer a priority for me.

If it were a new permission, I'd agree that we definitely want it conditional on the appropriate kernel version. Since it is a fix for a regression in checking an existing permission, it wasn't as clear to me. Won't matter for RHEL because the fs_filesystem tests are only enabled for >= 5.2 since the new system calls weren't added until then, so none of these tests will run on RHEL regardless. It would only show up on Fedora kernels from 5.2 through 5.5 that don't have the fix back-ported.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux