Re: [PATCH 1/5] libsepol: do not modify p->p_roles.nprim in role_set_expand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/23/2016 05:06 PM, Nicolas Iooss wrote:
> There is no reason to modify the number of roles defined in a policy
> when no role is being inserted.

Thanks, applied.

> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss@xxxxxxx>
> ---
>  libsepol/src/expand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libsepol/src/expand.c b/libsepol/src/expand.c
> index 32df6f8b2ce6..7244e01fb50d 100644
> --- a/libsepol/src/expand.c
> +++ b/libsepol/src/expand.c
> @@ -2424,7 +2424,7 @@ int role_set_expand(role_set_t * x, ebitmap_t * r, policydb_t * out, policydb_t
>  	ebitmap_init(r);
>  
>  	if (x->flags & ROLE_STAR) {
> -		for (i = 0; i < p->p_roles.nprim++; i++)
> +		for (i = 0; i < p->p_roles.nprim; i++)
>  			if (ebitmap_set_bit(r, i, 1))
>  				return -1;
>  		return 0;
> 

_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux