On Thu, Jun 23, 2016 at 10:52:54PM +0300, Dan Jurgens wrote:
> From: Daniel Jurgens <danielj@xxxxxxxxxxxx>
>
> Cache the subnet prefix and add a function to access it. Enforcing
> security requires frequent queries of the subnet prefix and the pkeys in
> the pkey table.
>
> Also removed an unneded pr_warn about memory allocation failure.
>
> Signed-off-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> Reviewed-by: Eli Cohen <eli@xxxxxxxxxxxx>
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> drivers/infiniband/core/cache.c | 35 +++++++++++++++++++++++++++++++++--
> drivers/infiniband/core/core_priv.h | 3 +++
> include/rdma/ib_verbs.h | 1 +
> 3 files changed, 37 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
> index c2e257d..4894e21 100644
> --- a/drivers/infiniband/core/cache.c
> +++ b/drivers/infiniband/core/cache.c
> @@ -926,6 +926,25 @@ int ib_get_cached_pkey(struct ib_device *device,
> }
> EXPORT_SYMBOL(ib_get_cached_pkey);
>
> +int ib_get_cached_subnet_prefix(struct ib_device *device,
> + u8 port_num,
> + u64 *sn_pfx)
> +{
> + unsigned long flags;
> + int p = port_num - rdma_start_port(device);
Suggesting to initialize p after the validation.
> +
> + if (port_num < rdma_start_port(device) ||
> + port_num > rdma_end_port(device))
> + return -EINVAL;
> +
> + read_lock_irqsave(&device->cache.lock, flags);
> + *sn_pfx = device->cache.subnet_prefix_cache[p];
> + read_unlock_irqrestore(&device->cache.lock, flags);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(ib_get_cached_subnet_prefix);
> +
> int ib_find_cached_pkey(struct ib_device *device,
> u8 port_num,
> u16 pkey,
> @@ -1102,6 +1121,8 @@ static void ib_cache_update(struct ib_device *device,
>
> device->cache.lmc_cache[port - rdma_start_port(device)] = tprops->lmc;
>
> + device->cache.subnet_prefix_cache[port - rdma_start_port(device)] =
> + tprops->subnet_prefix;
> write_unlock_irq(&device->cache.lock);
>
> kfree(gid_cache);
> @@ -1160,9 +1181,18 @@ int ib_cache_setup_one(struct ib_device *device)
> (rdma_end_port(device) -
> rdma_start_port(device) + 1),
> GFP_KERNEL);
> +
> + device->cache.subnet_prefix_cache = kcalloc((rdma_end_port(device) -
> + rdma_start_port(device) + 1),
> + sizeof(*device->cache.subnet_prefix_cache),
More than 80 characters.
> + GFP_KERNEL);
> +
> if (!device->cache.pkey_cache ||
> - !device->cache.lmc_cache) {
> - pr_warn("Couldn't allocate cache for %s\n", device->name);
> + !device->cache.lmc_cache ||
> + !device->cache.subnet_prefix_cache) {
> + kfree(device->cache.pkey_cache);
> + kfree(device->cache.lmc_cache);
> + kfree(device->cache.subnet_prefix_cache);
> return -ENOMEM;
> }
>
> @@ -1205,6 +1235,7 @@ void ib_cache_release_one(struct ib_device *device)
> gid_table_release_one(device);
> kfree(device->cache.pkey_cache);
> kfree(device->cache.lmc_cache);
> + kfree(device->cache.subnet_prefix_cache);
> }
>
> void ib_cache_cleanup_one(struct ib_device *device)
> diff --git a/drivers/infiniband/core/core_priv.h b/drivers/infiniband/core/core_priv.h
> index 19d499d..ce826e4 100644
> --- a/drivers/infiniband/core/core_priv.h
> +++ b/drivers/infiniband/core/core_priv.h
> @@ -153,4 +153,7 @@ int ib_nl_handle_set_timeout(struct sk_buff *skb,
> int ib_nl_handle_ip_res_resp(struct sk_buff *skb,
> struct netlink_callback *cb);
>
> +int ib_get_cached_subnet_prefix(struct ib_device *device,
> + u8 port_num,
> + u64 *sn_pfx);
> #endif /* _CORE_PRIV_H */
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index e522acb..c00b6b1 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -1637,6 +1637,7 @@ struct ib_cache {
> struct ib_pkey_cache **pkey_cache;
> struct ib_gid_table **gid_cache;
> u8 *lmc_cache;
> + u64 *subnet_prefix_cache;
> };
>
> struct ib_dma_mapping_ops {
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.
