On 04/29/2016 08:04 AM, Jason Zaman wrote:
> Signed-off-by: Jason Zaman <jason@xxxxxxxxxxxxx>
> ---
> libsemanage/src/genhomedircon.c | 40 ++++++++++++++++++++++++++++++++++++----
> 1 file changed, 36 insertions(+), 4 deletions(-)
>
> diff --git a/libsemanage/src/genhomedircon.c b/libsemanage/src/genhomedircon.c
> index 1a7882c..41fd7ff 100644
> --- a/libsemanage/src/genhomedircon.c
> +++ b/libsemanage/src/genhomedircon.c
> @@ -852,7 +872,19 @@ static genhomedircon_user_entry_t *get_users(genhomedircon_settings_t * s,
> }
> if (ignore(pwent->pw_dir))
> continue;
> - if (push_user_entry(&head, name, seuname,
> +
> + len = snprintf(uid, sizeof(uid), "%u", pwent->pw_uid);
> + if (len < 0 || len >= sizeof(uid)) {
> + *errors = STATUS_ERR;
> + goto cleanup;
> + }
> + len = snprintf(gid, sizeof(gid), "%u", pwent->pw_gid);
> + if (len < 0 || len >= sizeof(gid)) {
> + *errors = STATUS_ERR;
> + goto cleanup;
> + }
> +
> + if (push_user_entry(&head, name, uid, gid, seuname,
> prefix, pwent->pw_dir, level) != STATUS_SUCCESS) {
> *errors = STATUS_ERR;
> break;
>
$ make DESTDIR=~/obj clean install > make.out
genhomedircon.c: In function ‘get_users’:
genhomedircon.c:910:22: error: comparison between signed and unsigned
integer expressions [-Werror=sign-compare]
if (len < 0 || len >= sizeof(uid)) {
^
genhomedircon.c:915:22: error: comparison between signed and unsigned
integer expressions [-Werror=sign-compare]
if (len < 0 || len >= sizeof(gid)) {
^
cc1: all warnings being treated as errors
make[2]: *** [genhomedircon.o] Error 1
make[1]: *** [install] Error 2
make: *** [install] Error 1
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.
