Hi all, I finally finished adding more templates to genhomedircon and a lot of general cleanups. The first few patches refactor the templating functions so they are smaller and easier to add new. All the common bits were taken out and they all take the user_entry_t struct instead of passing args one by one. The last three patches add the new templating types. I went with %{USERID} and %{USERNAME}. They now have a clear start and end unlike USER in the past and $ is end of line in regexes so % seems safer. The matcher for USER now specifically excludes any line that has the new patterns in it too so there can be no conflict. It appears to work in the testing I have done with adding strange fcontexts. make test passes in the repo too but i have not run the full selinux-testsuite. %{USERNAME} defaults to ".*" in the fallback just like USER originally did %{USERID} defaults to "[0-9]+" for the fallback. Another thing I noticed was that HOME_DIR's fallback is "[^/]*", should it be + instead of *? I dont think it makes a huge difference because then it should match HOME_ROOT but it still seems wrong. -- Jason _______________________________________________ Selinux mailing list Selinux@xxxxxxxxxxxxx To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx. To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.