[PATCH] fixfiles: make sure $LOGFILE starts with a slash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



`tty` may output a (localized) "not a tty" message to stdout and exit with a
zero status in case ttyname(3) returns NULL but isatty(3) returns success. 
This happens at least when stdin is connected to a tty but we're inside a
chroot with no access to the tty file.

This results in an error:

    /usr/sbin/fixfiles: line 257: $LOGFILE: ambiguous redirect

Handle `tty` results that don't start with a slash the same way as no tty
errors: point $LOGFILE to /dev/null.

Signed-off-by: Oskari Saarenmaa <os@xxxxxxxx>
---
 policycoreutils/scripts/fixfiles | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/policycoreutils/scripts/fixfiles b/policycoreutils/scripts/fixfiles
index 5c29eb9..1c64191 100755
--- a/policycoreutils/scripts/fixfiles
+++ b/policycoreutils/scripts/fixfiles
@@ -120,7 +120,7 @@ FORCEFLAG=""
 DIRS=""
 RPMILES=""
 LOGFILE=`tty`
-if [ $? != 0 ]; then
+if [ $? != 0 -o ${LOGFILE:0:1} != "/" ]; then
     LOGFILE="/dev/null"
 fi
 LOGGER=/usr/sbin/logger
-- 
2.5.5
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux