Re: [PATCH v1 1/1] selinux: use absolute path to include directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 19, 2016 at 11:11 AM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Tue, 2016-01-19 at 10:53 -0500, Paul Moore wrote:
>> On Fri, Dec 4, 2015 at 3:07 PM, Andy Shevchenko
>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>> > Compiler warns us a lot that it can't find include folder because
>> > it's provided
>> > in relative form.
>> >
>> >   CC      security/selinux/netlabel.o
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> > cc1: warning: security/selinux/include: No such file or directory
>> > [-Wmissing-include-dirs]
>> >
>> > Add $(srctree) prefix to the path.
>> >
>> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> > ---
>> >  security/selinux/Makefile | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/security/selinux/Makefile b/security/selinux/Makefile
>> > index ad5cd76..90d1adb 100644
>> > --- a/security/selinux/Makefile
>> > +++ b/security/selinux/Makefile
>> > @@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
>> >
>> >  selinux-$(CONFIG_NETLABEL) += netlabel.o
>> >
>> > -ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
>> > +ccflags-y := -Isecurity/selinux
>> > -I$(srctree)/security/selinux/include
>>
>> Why not add the $(srctree) prefix to both paths?
>
> I don't care as long as it fixes the annoying messages. Though, I can
> re-do the patch if it looks better that way.

Please do.

-- 
paul moore
www.paul-moore.com
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux