Re: [PATCH] hiding SELinux status on Settings app if HAVE_SELINUX:=false

[William Roberts <bill.c.roberts@xxxxxxxxx>]

Ahh your comment in Garret said, "willing to abandon", didn't realize you did. How can you go about getting that patchset marked as (abandoned) in Garret and can you please do that?

On another note, I see at times that it's hard getting around the HAVE_SELINUX in java code since their is no conditional compilation. It looks like the build prop is a cleaner way of handling this. Should we keep the change in libcore and merge that?

I still think having the selinux status in Settings is useful as it doesn't require me to bake in an app for it.

Bill

On Mon, Jun 25, 2012 at 5:12 AM, Stephen Smalley <sds@xxxxxxxxxxxxx> wrote:

On Fri, 2012-06-22 at 13:43 -0700, William Roberts wrote:
> This should hide the SELinux status in settings if you don't have
> HAVE_SELINUX:=true during the build.
>
>
> Please verify these patches before merging them. I only tested on
> Maguro.
>
>
> Right now, you must do a CLEAN build to get these to work right. For
> some reason props doesn't get updated right for me.
>
>
> These for addressing the issues in Change-Id:
> I69529fb7a3adfe31eccb16d79740fc4952ff5e68 on garret

I was going to just drop the Settings app change since we now have
SEAndroidManager and it provides a superset of the Settings app
functionality (and has the benefit of being easily included/excluded in
different product builds).

--
Stephen Smalley
National Security Agency

--
Respectfully,

William C Roberts