On Wed, 2011-09-14 at 00:05 +0200, Guido Trentalancia wrote: > Hello Eric ! > > On Tue, 2011-09-13 at 16:26 -0400, Eric Paris wrote: > > Personally, I'd like to see just 'make' at the top level dir build > > properly and I think your patches get us most of the way there without > > (further) breaking the building method that sds prefers. > > > > If you get your best patch which does nothing but allow us to just type > > 'make' at the top level dir and it builds everything properly in place, > > I'll review and probably commit such a patch. > > Yes, let's get to the point. The latest version of the patch that you > should test is attached below. Please note that it also changes the > creation of symbolic links to shared libraries (needs to be > double-checked for correctness). > > diff -pruN selinux/checkpolicy/Makefile selinux-13092011/checkpolicy/Makefile > --- selinux/checkpolicy/Makefile 2011-09-09 20:12:55.978662153 +0200 > +++ selinux-13092011/checkpolicy/Makefile 2011-09-13 02:58:19.314224502 +0200 > @@ -19,7 +19,7 @@ CHECKOBJS = y.tab.o lex.yy.o queue.o mod > CHECKPOLOBJS = $(CHECKOBJS) checkpolicy.o > CHECKMODOBJS = $(CHECKOBJS) checkmodule.o > > -LDLIBS=$(LIBDIR)/libsepol.a -lfl > +LDLIBS=../libsepol/src/libsepol.a -L$(LIBDIR) -lfl > > GENERATED=lex.yy.c y.tab.c y.tab.h The above will break when building checkpolicy separately. Ditto for the other components that need to reference a static lib. I think this is why we didn't go down this path previously. BTW, your patch wouldn't quite compile as is for me even aside from this issue; you don't seem to have defined LIBDIR in policycoreutils/restorecond/Makefile before using it. -- Stephen Smalley National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
