Re: [PATCH] Fix includes for userspace tools and libraries (and possible security issue)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-09-13 at 22:04 +0200, Guido Trentalancia wrote:
> It is up to the maintainer to keep the SUBDIRS variable ordered
> (according to the dependency relations).
> 
> See for example:
> 
> http://www.gnu.org/s/hello/manual/make/Phony-Targets.html#Phony-Targets
> http://www.gnu.org/s/hello/manual/automake/Subdirectories.html

Ok, we have ordered SUBDIRS in the Makefile in such a manner that each
component is built before anything that depends on it.

> > In your case, the sepol headers should have
> > already been installed before trying to build libselinux, and I don't
> > know why that didn't happen for you unless your make reorders SUBDIRS
> > internally or the make install in libsepol failed to complete (but I
> > wouldn't expect it to proceed in that case).
> 
> The make tool should not reorder variables in any case.

Good.

> I did not issue a "make install" (yet). I did just issue "make" from the
> top-level directory.

Right, that can't work and never has, which is why 'make' used to invoke
'make install' until Eric (incorrectly) changed that behavior.

> I am not building the components separately, I am building the whole
> bundle (tools + libraries) from the top-level directory of the git
> version. That's the point.

Understood, and the only way to do that has always been make
DESTDIR=~/out.  Reverting/fixing the changes that have broken that
behavior is the right solution.

Looking at your last patch, I don't see how it can possibly work in the
case where one isn't building the entire source tree (e.g. for package
building), because it encodes a relative path to the static libs in
LDLIBS.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.


[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux