Re: [RFC] Userspace top-level Makefile (was Re: [PATCH] Fix LIBDIR usage for load_policy)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Guido Trentalancia wrote:
-all install relabel clean test indent:
+all relabel test indent:
  	@for subdir in $(SUBDIRS); do \
-		(cd $$subdir&&  $(MAKE) $@) || exit 1; \
+		(cd $$subdir&&  $(MAKE) $@&&  $(MAKE) install) || exit 1; \
+	done
+	@for subdir_bin in $(SUBDIRS_BIN); do \
+		(cd $$subdir_bin&&  $(MAKE) $@) || exit 1; \
+	done
+
+install:
+	@for subdir in $(SUBDIRS); do \
+		(cd $$subdir&&  $(MAKE) install) || exit 1; \
+	done
+	@for subdir_bin in $(SUBDIRS_BIN); do \
+		(cd $$subdir_bin&&  $(MAKE) install) || exit 1; \
  	done

  install-pywrap swigify:
@@ -17,6 +29,14 @@ install-pywrap swigify:
  		(cd $$subdir&&  $(MAKE) $@) || exit 1; \
  	done


Nack. We can't require install in the build target and bail if it fails, this is completely unfriendly to developers who don't want to install all the libraries on their system during development, and those are the people using git.

If you are doing work on libselinux and you install it to your system before testing it locally you can easily break your machine and have to boot from a rescue disk.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.


[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux