On Thu, 20 Jan 2011, Davidlohr Bueso wrote: > From: Davidlohr Bueso <dave@xxxxxxx> > > Signed-off-by: Davidlohr Bueso <dave@xxxxxxx> > --- > security/selinux/ss/conditional.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c > index c3f845c..a533732 100644 > --- a/security/selinux/ss/conditional.c > +++ b/security/selinux/ss/conditional.c > @@ -178,7 +178,7 @@ int cond_init_bool_indexes(struct policydb *p) > p->bool_val_to_struct = (struct cond_bool_datum **) > kmalloc(p->p_bools.nprim * sizeof(struct cond_bool_datum *), GFP_KERNEL); > if (!p->bool_val_to_struct) > - return -1; > + return -ENOMEM; > return 0; The caller has already set -ENOMEM, so the code should probably be updated there, too, e.g. rc = cond_init_bool_indexes(); if (rc) goto out; -- James Morris <jmorris@xxxxxxxxx> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.