-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Quality Engineering is going through all commands on the system looking for mismatches between man page/usage and actual code. It found that checkmodule had a -d option that is unused and undocumented -h -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkvfC7oACgkQrlYvE4MpobNPrACg0uP02CWYPs9YcdU87jts9YqT hMAAn2QA1UWZpGLvvU4yxStmhUU1Kg1+ =topF -----END PGP SIGNATURE-----
diff --git a/checkpolicy/checkmodule.8 b/checkpolicy/checkmodule.8 index 550b32b..a25f25c 100644 --- a/checkpolicy/checkmodule.8 +++ b/checkpolicy/checkmodule.8 @@ -3,7 +3,7 @@ checkmodule \- SELinux policy module compiler .SH SYNOPSIS .B checkmodule -.I "[-b] [-m] [-M] [-V] [-o output_file] [input_file]" +.I "[-h] [-b] [-m] [-M] [-U handle_unknown ] [-V] [-o output_file] [input_file]" .SH "DESCRIPTION" This manual page describes the .BR checkmodule @@ -25,6 +25,9 @@ the module package into the module store and load the resulting policy. Read an existing binary policy module file rather than a source policy module file. This option is a development/debugging aid. .TP +.B \-h +Print usage. +.TP .B \-m Generate a non-base policy module. .TP diff --git a/checkpolicy/checkmodule.c b/checkpolicy/checkmodule.c index ad5a3d4..47603e0 100644 --- a/checkpolicy/checkmodule.c +++ b/checkpolicy/checkmodule.c @@ -139,13 +139,14 @@ static int write_binary_policy(policydb_t * p, char *file, char *progname) static void usage(char *progname) { - printf("usage: %s [-V] [-b] [-U handle_unknown] [-m] [-M] [-o FILE] [INPUT]\n", progname); + printf("usage: %s [-h] [-V] [-b] [-U handle_unknown] [-m] [-M] [-o FILE] [INPUT]\n", progname); printf("Build base and policy modules.\n"); printf("Options:\n"); printf(" INPUT build module from INPUT (else read from \"%s\")\n", txtfile); printf(" -V show policy versions created by this program\n"); printf(" -b treat input as a binary policy file\n"); + printf(" -h print usage\n"); printf(" -U OPTION How to handle unknown classes and permissions\n"); printf(" deny: Deny unknown kernel checks\n"); printf(" reject: Reject loading of policy with unknowns\n"); @@ -169,7 +170,6 @@ int main(int argc, char **argv) {"binary", no_argument, NULL, 'b'}, {"version", no_argument, NULL, 'V'}, {"handle-unknown", optional_argument, NULL, 'U'}, - {"debug", no_argument, NULL, 'd'}, {"mls", no_argument, NULL, 'M'}, {NULL, 0, NULL, 0} };
Attachment:
checkpolicy-getopt.patch.sig
Description: PGP signature