(2010/02/09 16:09), KaiGai Kohei wrote: > (2010/02/08 8:14), James Morris wrote: >> Please review. >> >> These warnings were introduced in commit >> 44c2d9bdd7022ca7d240d5adc009296fc1c6ce08 > > Please wait for a few days more. > > It might be the right answer to revert this commit, not fixing > compiler warning. > > http://marc.info/?l=selinux&m=126569829629708&w=2 Sorry, I might be confused. I misunderstood what we were talking about this commit: 7d52a155e38d5a165759dbbee656455861bf7801 This cleanup is not related to the topic I pointed out above. And, it seems to me fair enough. Acked-by: KaiGai Kohei <kaigai@xxxxxxxxxxxxx> >> ---- >> >> >> selinux: fix a couple of sparse warnings >> >> Fix a couple of sparse warnings for callers of >> context_struct_to_string, which takes a *u32, not an *int. >> >> These cases are harmless as the values are not used. >> >> Signed-off-by: James Morris<jmorris@xxxxxxxxx> >> >> diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c >> index 4e976f5..0e5c3a4 100644 >> --- a/security/selinux/ss/services.c >> +++ b/security/selinux/ss/services.c >> @@ -455,7 +455,8 @@ static void security_dump_masked_av(struct context *scontext, >> char *scontext_name = NULL; >> char *tcontext_name = NULL; >> char *permission_names[32]; >> - int index, length; >> + int index; >> + u32 length; >> bool need_comma = false; >> >> if (!permissions) >> @@ -807,7 +808,7 @@ int security_bounded_transition(u32 old_sid, u32 new_sid) >> if (rc) { >> char *old_name = NULL; >> char *new_name = NULL; >> - int length; >> + u32 length; >> >> if (!context_struct_to_string(old_context, >> &old_name,&length)&& >> -- OSS Platform Development Division, NEC KaiGai Kohei <kaigai@xxxxxxxxxxxxx> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
