Re: SIS7012(i810_audio) not working

[Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>]

On Gwe, 2003-06-06 at 06:19, Bill Long wrote:
> I'm kind of new. Does that mean the patches are going to the linux
> kernel? or to the SIS guys to modify their driver?

Into the Linux kernel. The sis stuff is supported by a non SiS driver
as its a sort of clone of the intel i8xx audio.

> Would it be possible to get those patches? or is it best to wait for it
> to be released?

See attached

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.21rc7/drivers/sound/ac97_codec.c linux.21rc7-ac1/drivers/sound/ac97_codec.c
--- linux.21rc7/drivers/sound/ac97_codec.c	2003-06-03 23:30:29.000000000 +0100
+++ linux.21rc7-ac1/drivers/sound/ac97_codec.c	2003-06-02 20:06:55.000000000 +0100
@@ -805,8 +860,6 @@
 	if (!(cap & 0x10))
 		codec->supported_mixers &= ~SOUND_MASK_ALTPCM;
 
-	if(codec->flags & AC97_NO_PCM_VOLUME)
-		codec->supported_mixers &= ~SOUND_MASK_PCM;
 
 	/* detect bit resolution */
 	codec->codec_write(codec, AC97_MASTER_VOL_STEREO, 0x2020);
@@ -836,8 +889,15 @@
 		ac97_set_mixer(codec, md->mixer, md->value);
 	}
 
+	/*
+	 *	Volume is MUTE only on this device. We have to initialise
+	 *	it but its useless beyond that.
+	 */
 	if(codec->flags & AC97_NO_PCM_VOLUME)
+	{
+		codec->supported_mixers &= ~SOUND_MASK_PCM;
 		printk(KERN_WARNING "AC97 codec does not have proper volume support.\n");
+	}
 	return 1;
 }