Re: [PATCH 4/4] reiserfs: rework reiserfs_snprintf to not abuse va_list (as much)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 11-04-18 12:52:00, Rasmus Villemoes wrote:
> On 2018-04-11 11:48, Jan Kara wrote:
> > 
> > Well, you are correct it won't work as I originally suggested but it should
> > work like:
> > 
> > #define vsnprintf(buf, len, fmt, ap) new_vsnprintf((buf), (len), (fmt), &(ap))
> > 
> > That way there's practically zero overhead for current vsnprintf() users
> > and no type issues...
> 
> That only works for the callers who declared ap locally, not those that
> somehow received ap as an argument (one example would be kvasprintf).

Hum, right. Thanks for careful review ;).

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux File System Development]     [Linux BTRFS]     [Linux NFS]     [Linux Filesystems]     [Ext4 Filesystem]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Resources]

  Powered by Linux