On 2025-02-05, John Ogness <john.ogness@xxxxxxxxxxxxx> wrote: >> OK, so I don't need to add "if (IS_ENABLED(CONFIG_PREEMPT_RT))" to guard >> it, then? > > For !CONFIG_PREEMPT_RT, if there are legacy consoles registered, > pr_flush() will additionally perform a blocking lock on the > console_lock. Sorry, I was just thinking about the flushing component of pr_flush(). Later in the function it takes the console_lock even for CONFIG_PREEMPT_RT. So please do _not_ have a guard. pr_flush() should never hang on the console_lock during shutdown, but if does, that is something that will need to be debugged and fixed. @pmladek: Looking forward to reading your input on this. John
