On 7/26/23 17:07, Paul E. McKenney wrote:
>> - free_percpu(ssp->sda);
>> - ssp->sda = NULL;
>> - kfree(ssp->srcu_sup);
>> - return -ENOMEM;
>> - }
>> - } else {
>> + if (!init_srcu_struct_nodes(ssp, GFP_ATOMIC))
>> + goto err_free_sda;
>> + else
>> WRITE_ONCE(ssp->srcu_sup->srcu_size_state, SRCU_SIZE_BIG);
> Given that the "then" clause is a goto, what is the "else" clause doing
> for us?
>
Not much. Agreed we can get rid of "else" and reduce indent of the
WRITE_ONCE that follows.
Would you mind making this fixup in the patch for your apply, or would
you like me to refresh the patch? Let me know either way, thank you!
- Joel
