On Tue, Mar 21, 2023 at 01:21:21AM +0000, Zhuo, Qiuxu wrote: > > From: Paul E. McKenney <paulmck@xxxxxxxxxx> > > Sent: Tuesday, March 21, 2023 4:41 AM > > [...] > > > > > > Fixes: e6e78b004fa7 ("rcuperf: Add kfree_rcu() performance Tests") > > > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx> > > > > Much better! > > > > Except that someone glancing at this patch would be hard pressed to see > > what changed. > > Indeed. > > > So could you please split this into two patches, the first of which does > > nothing but move code, and the second of which makes the actual change? > > OK. > Will split this patch into two patches in the v3. > > > The commit log for the first patch needs to clearly state that the it is code- > > motion-only, with no change in behavior. > > OK. > Thanks so much for your suggestions ;-) Looking forward to seeing the next version! Thanx, Paul