Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
From: "Theodore Ts'o" <tytso@xxxxxxx>
Date: Wed, 15 Mar 2023 20:42:27 -0400
Cc: Uladzislau Rezki <urezki@xxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, RCU <rcu@xxxxxxxxxxxxxxx>, "Paul E . McKenney" <paulmck@xxxxxxxxxx>, Oleksiy Avramchenko <oleksiy.avramchenko@xxxxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Bryan Tan <bryantan@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Bob Pearson <rpearsonhpe@xxxxxxxxx>, Ariel Levkovich <lariel@xxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>
In-reply-to: <20230315153448.6914f85b@gandalf.local.home>

On Wed, Mar 15, 2023 at 03:34:48PM -0400, Steven Rostedt wrote:
> 
> Still, I will replace that code back to a kfree() and rcu_synchonize() than
> to let that other name get in.

That will have a performance hit relaive to kfree_rcu_mightsleep().
If that's OK with you, sure, you can do that.

Personally, I don't have a lot of problem with that name, which is why
I ack'ed the change for ext4.

						- Ted

References:
- [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
  - From: Uladzislau Rezki (Sony)
- Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
  - From: Steven Rostedt
- Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
  - From: Jens Axboe
- Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
  - From: Uladzislau Rezki
- Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
  - From: Steven Rostedt

Prev by Date: Re: [PATCH 04/13] tracing: Rename kvfree_rcu() to kvfree_rcu_mightsleep()
Next by Date: Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
Previous by thread: Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
Next by thread: [PATCH 10/13] ipvs: Rename kfree_rcu() to kfree_rcu_mightsleep()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]