On Wed, 15 Mar 2023 20:25:10 +0100 Uladzislau Rezki <urezki@xxxxxxxxx> wrote: > > This was my main complaint too, kvfree_rcu_mightsleep() is an absolutely > > horrible name for an API... But nobody seemed to care about that! > > > > I like the _synchronize() suggestion, as it matches other RCU naming. > > > This is basically about what it does. If you renamed it to "_synchronize()" > in reality it would not mean that it always a synchronous call, most of the > time it is not whereas the name would point that it is. No, just comment it. I was going to suggest "kvfree_rcu_might_synchronize()" but that's just getting ridiculous. Still, I will replace that code back to a kfree() and rcu_synchonize() than to let that other name get in. -- Steve
