On Wed, Aug 14, 2024 at 03:00:06PM +0100, John Garry wrote: > - __blkdev_issue_write_zeroes(bdev, sector, nr_sects, gfp, &bio, > flags); > + __blkdev_issue_write_zeroes(bdev, sector, nr_sects, gfp, &bio, > flags, limit); Please fix the overly long line while touching this. > { > + > + sector_t limit = bio_write_zeroes_limit(bdev); > if (bdev_read_only(bdev)) > return -EPERM; Can you add a comment explaining why the limit is read once for future readers? Also please keep an empty line after the variable declaration instead of before it.