Re: [bug report] raid0 array mkfs.xfs hang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 14, 2024 at 03:00:06PM +0100, John Garry wrote:
> -       __blkdev_issue_write_zeroes(bdev, sector, nr_sects, gfp, &bio, 
> flags);
> +       __blkdev_issue_write_zeroes(bdev, sector, nr_sects, gfp, &bio, 
> flags, limit);

Please fix the overly long line while touching this.

>  {
> +
> +       sector_t limit = bio_write_zeroes_limit(bdev);
>         if (bdev_read_only(bdev))
>                 return -EPERM;

Can you add a comment explaining why the limit is read once for future
readers?  Also please keep an empty line after the variable declaration
instead of before it.





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux