On Tue, Jun 25, 2024 at 12:24:07PM +0100, John Garry wrote:
> On 25/06/2024 12:05, Christoph Hellwig wrote:
> > @@ -351,7 +351,7 @@ static int blk_validate_limits(struct queue_limits *lim)
> > if (lim->alignment_offset) {
> > lim->alignment_offset &= (lim->physical_block_size - 1);
> > - lim->features &= ~BLK_FEAT_MISALIGNED;
> > + lim->features &= ~BLK_FLAG_MISALIGNED;
>
> The comment for enum which BLK_FLAG_MISALIGNED is a member of reads
> "internal flags for queue_limits.flags", so it might help to comment why we
> clear in lim->features (if correct to do so).
Or fix that as well. And probably move to a __bitwise type to make
sparse catch this.
