Re: [PATCH 3/7] block: rename BLK_FLAG_MISALIGNED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/06/2024 12:05, Christoph Hellwig wrote:
@@ -351,7 +351,7 @@ static int blk_validate_limits(struct queue_limits *lim)
if (lim->alignment_offset) {
  		lim->alignment_offset &= (lim->physical_block_size - 1);
-		lim->features &= ~BLK_FEAT_MISALIGNED;
+		lim->features &= ~BLK_FLAG_MISALIGNED;

The comment for enum which BLK_FLAG_MISALIGNED is a member of reads "internal flags for queue_limits.flags", so it might help to comment why we clear in lim->features (if correct to do so).

  	}





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux