Hi Paul, thanks for your review, I sent the corrections in V2. On Mon, 18 Mar 2024 18:56:42 +0100 Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > Dear Blazej, > > > Am 18.03.24 um 17:25 schrieb Blazej Kucman: > > For NVMe devices with Opal support, encryption information, status > > and ability are completed based on Opal Level 0 discovery response. > > > > What do you mean by “are completed”? > indeed, this word may not be precise, I meant "determined", I changed it in V2. and as for this comment > Maybe document how to test this feature, preferebly with QEMU. I added to patch "imsm: print disk encryption information", example outputs for the new feature usage, for various cases, especially SATA, it shows how it can be tested. Thansk, Blazej
