On 6/1/23 03:27, Mariusz Tkaczyk wrote: > Hi Jes, > To avoid problem with udev and VROC UEFI driver I developed stronger > naming policy, basing on POSIX portable names standard. Verification is > added for names and config entries. In case of an issue, user can update > name to make it compatible (for IMSM and native). > > The changes here may cause /dev/md/ link will be different than before > mdadm update. To make any of that happen user need to use unusual naming > convention, like: > - special, non standard signs like, $,%,&,* or space. > - '-' used as first sign. > - locals. > > Note: I didn't analyze configurations with "names=1". If name cannot be > determined mdadm should fallback to default numbered dev creation. > > If you are planning release soon then feel free to merge it after the > release. It is a potential regression point. > > It is a new version of [1] but it is strongly rebuild. Here is a list > of changes: > 1. negative and positive test scenarios for both create and config > entries are added. > 2. Save parsed parameters in dedicated structs. It is a way to control > what is parsed, assuming that we should use dedicated set_* function. > 3. Verification for config entries is added. > 5. Improved error logging for names: > - during creation, these messages are errors, printed to stderr. > - for config entries, messages are just a warnings printed to stdout. > 6. Error messages reworked. > 7. Updates in manual. > > [1] https://lore.kernel.org/linux-raid/20221221115019.26276-1-mariusz.tkaczyk@xxxxxxxxxxxxxxx/ > > Mariusz Tkaczyk (6): > tests: create names_template > tests: create 00confnames > mdadm: set ident.devname if applicable > mdadm: refactor ident->name handling > mdadm: define ident_set_devname() > mdadm: Follow POSIX Portable Character Set Hi, it seems to me that the behavior after this change is inconsistent. The default naming scheme for a created device is still <HOSTNAME>:<ID>. When I create a new MD device with: # mdadm --version mdadm - v4.2 - 2021-12-30 - Debian 4.2+20231121-1 # mdadm --create /dev/md32 -l 1 -n 2 /dev/loop2 /dev/loop3 [...] # mdadm --detail /dev/md32 /dev/md32: Version : 1.2 Creation Time : Mon Jan 1 12:33:05 2024 [...] Name : gondolin:32 (local to host gondolin) UUID : d84b8e26:3675a722:61869b83:670699da The name set automatically by mdadm is not allowed by the new naming rules, and mdadm complains about that later on. So for consistency one would either have to include : in the allowed character list or change the default naming scheme. Or am I missing something here? Happy new year! Stefan
