On Thu, Dec 28, 2023 at 6:28 AM Mateusz Kusiak <mateusz.kusiak@xxxxxxxxxxxxxxx> wrote: [...] > > # create a raid0, re-assemble with a different super-minor > + > +if [ "$LINEAR" != "yes" ]; then > + echo -ne 'skipping... ' > + exit 0 > +fi > + > mdadm -CR -e 0.90 $md0 -llinear -n3 $dev0 $dev1 $dev2 > testdev $md0 3 $mdsize0 1 > minor1=`mdadm -E $dev0 | sed -n -e 's/.*Preferred Minor : //p'` > > Hi Song, this approach looks a bit dirty to me as it's omitting what's already in the test suite. I would prefer adding additional param rather than setting environment variable, so test execution flow stays unified (as far as I'm aware we do not use flags for now). Adding param is also a good excuse to explain why linear is not tested by default in "--help". We have something similar to this in tests/00multipath, so I used this pattern. Thanks, Song > > Another thing is "--raidtype=linear" option, is probably redundant now. > > Thanks, Mateusz
