On Thu, Feb 23, 2023 at 12:48:58AM +0100, Reindl Harald wrote:
> > > + if (io_size != opt_size &&
> > > + start + opt_size / SECTOR_SIZE <= boundary)
> > > + return opt_size;
> > > + else if (start + io_size / SECTOR_SIZE <= boundary)
> >
> > No need for an else after a return.
> >
> > Otherwise looks good:
> >
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> the "return" is within the if-condition and has nothing to do with the else
> - with {} it would be clearly visible
That doesn't change the fact that it's not actually needed.
